Conversation
The product generation phase logs progress every 1%, but the xlsx cell writing and attachment public update had no logging. With 36K rows and 344 columns (~12M cells), this phase takes significant time after the 100% generation message, leaving the user with no feedback. Add progress logging for the xlsx writing loop and the attachment public update at the end.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 16.0 #94 +/- ##
==========================================
- Coverage 43.65% 43.60% -0.05%
==========================================
Files 283 283
Lines 8096 8104 +8
Branches 1563 1564 +1
==========================================
Hits 3534 3534
- Misses 4467 4475 +8
Partials 95 95 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary